From: Juan Castillo Date: Thu, 22 Oct 2015 10:34:44 +0000 (+0100) Subject: Make: fix dependency files generation X-Git-Url: http://git.openwrt.org/%22https:/collectd.org//%22http:/www.crowdsec.net/%22/%22https:/collectd.org/%22http:/www.crowdsec.net/%22?a=commitdiff_plain;h=88154678c5e6d0e6e28ca17beb01049a9ea4c0a0;p=project%2Fbcm63xx%2Fatf.git Make: fix dependency files generation Currently, if no make goal is specified in the command line, 'all' is assumed by default, but the dependency files are not generated. This might lead to a successful but inconsistent build. This patch provides a fix to the problem. Change-Id: I0148719e114dbdbe46f8a57c7d05da7cbc212c92 --- diff --git a/Makefile b/Makefile index 31ac5d6f..ac059e82 100644 --- a/Makefile +++ b/Makefile @@ -34,6 +34,9 @@ VERSION_MAJOR := 1 VERSION_MINOR := 1 +# Default goal is build all images +.DEFAULT_GOAL := all + include make_helpers/build_macros.mk ################################################################################ @@ -375,9 +378,6 @@ endif # Build targets ################################################################################ -# Default target -.DEFAULT_GOAL := all - .PHONY: all msg_start clean realclean distclean cscope locate-checkpatch checkcodebase checkpatch fiptool fip certtool .SUFFIXES: diff --git a/make_helpers/build_macros.mk b/make_helpers/build_macros.mk index 0e2e2ac9..9ab6e648 100644 --- a/make_helpers/build_macros.mk +++ b/make_helpers/build_macros.mk @@ -112,6 +112,12 @@ endef # Auxiliary macros to build TF images from sources ################################################################################ +# If no goal is specified in the command line, .DEFAULT_GOAL is used. +# .DEFAULT_GOAL is defined in the main Makefile before including this file. +ifeq ($(MAKECMDGOALS),) +MAKECMDGOALS := $(.DEFAULT_GOAL) +endif + define match_goals $(strip $(foreach goal,$(1),$(filter $(goal),$(MAKECMDGOALS)))) endef